From 604d2c6c1e4fcc735ed1fbe6aefbca3954916124 Mon Sep 17 00:00:00 2001 From: Mickael Remond Date: Sat, 29 Jun 2019 17:48:38 +0200 Subject: [PATCH] Improves comments --- session.go | 1 + stanza/sasl_auth.go | 1 + 2 files changed, 2 insertions(+) diff --git a/session.go b/session.go index c4bf804..4fe8bcf 100644 --- a/session.go +++ b/session.go @@ -179,6 +179,7 @@ func (s *Session) rfc3921Session(o Config) { } var iq stanza.IQ + // We only negotiate session binding if it is mandatory, we skip it when optional. if !s.Features.Session.IsOptional() { fmt.Fprintf(s.streamLogger, "", s.PacketId(), stanza.NSSession) if s.err = s.decoder.Decode(&iq); s.err != nil { diff --git a/stanza/sasl_auth.go b/stanza/sasl_auth.go index 8bd4e06..d04174f 100644 --- a/stanza/sasl_auth.go +++ b/stanza/sasl_auth.go @@ -99,6 +99,7 @@ func (s *StreamSession) IsOptional() bool { if s.XMLName.Local == "session" { return s.Optional } + // If session element is missing, then we should not use session return true }