narayana/conversations-classic
3
2
Fork 0
Code Issues 3 Pull requests 2 Actions Packages Projects Releases 4 Wiki Activity

Set navigation bar color to dark on dark theme (#3091)

Browse source 
* Allow overriding ConversationsTheme.Dark

This change splits the dark theme style into two styles - base that
stays the same in all configurations and Dark - the original - that can
be overridden in specific configurations to add version specific styles.

* Set navigation bar color to dark on dark theme

Use secondary background color as navigation bar color when using dark
theme. This avoids mismatched white colors on certain system themes.
This commit is contained in:
Wiktor 2018-06-25 19:40:37 +02:00 committed by Daniel Gultsch
parent 9a4109eaa1
commit 5345befd9b
2 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/main/res/values-v21/themes.xml Normal file
View file

@ -0,0 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<style name="ConversationsTheme.Dark" parent="ConversationsTheme.Dark.Base">
<item name="android:navigationBarColor">@color/grey900</item>
</style>
</resources>

4
src/main/res/values/themes.xml
View file

@ -99,7 +99,9 @@
<item type="reference" name="icon_enable_undecided_device">@drawable/ic_new_releases_black_24dp</item> <item type="reference" name="icon_enable_undecided_device">@drawable/ic_new_releases_black_24dp</item>
</style> </style>
<style name="ConversationsTheme.Dark" parent="Theme.AppCompat.NoActionBar"> <style name="ConversationsTheme.Dark" parent="ConversationsTheme.Dark.Base" />
<style name="ConversationsTheme.Dark.Base" parent="Theme.AppCompat.NoActionBar">
<item name="colorPrimary">@color/green800</item> <item name="colorPrimary">@color/green800</item>
<item name="colorPrimaryDark">@color/green900</item> <item name="colorPrimaryDark">@color/green900</item>
<item name="colorAccent">@color/blue_a100</item> <item name="colorAccent">@color/blue_a100</item>