narayana/conversations-classic
3
2
Fork 0
Code Issues 3 Pull requests 2 Actions Packages Projects Releases 4 Wiki Activity

EmojiService: use replaceAll=false on android 8

Browse source
This commit is contained in:
Daniel Gultsch 2018-07-05 13:22:32 +02:00
parent 88a7186ace
commit 3782a6fac6
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/freeCompat/java/eu/siacs/conversations/ui/service/EmojiService.java
View file

@ -21,7 +21,11 @@ public class EmojiService {
public void init() { public void init() {
BundledEmojiCompatConfig config = new BundledEmojiCompatConfig(context); BundledEmojiCompatConfig config = new BundledEmojiCompatConfig(context);
config.setReplaceAll(true); //On recent Androids we assume to have the latest emojis
//there are some annoying bugs with emoji compat that make it a safer choice not to use it when possible
// a) the text preview has annoying glitches when the cut of text contains emojis (the emoji will be half visible)
// b) can trigger a hardware rendering bug https://issuetracker.google.com/issues/67102093
config.setReplaceAll(Build.VERSION.SDK_INT < Build.VERSION_CODES.O);
EmojiCompat.init(config); EmojiCompat.init(config);
} }

1
src/playstoreCompat/java/eu/siacs/conversations/ui/service/EmojiService.java
View file

@ -46,6 +46,7 @@ public class EmojiService {
//there are some annoying bugs with emoji compat that make it a safer choice not to use it when possible //there are some annoying bugs with emoji compat that make it a safer choice not to use it when possible
// a) when using the ondemand emoji font (play store) flags don’t work // a) when using the ondemand emoji font (play store) flags don’t work
// b) the text preview has annoying glitches when the cut of text contains emojis (the emoji will be half visible) // b) the text preview has annoying glitches when the cut of text contains emojis (the emoji will be half visible)
// c) can trigger a hardware rendering bug https://issuetracker.google.com/issues/67102093
fontRequestEmojiCompatConfig.setReplaceAll(Build.VERSION.SDK_INT < Build.VERSION_CODES.O); fontRequestEmojiCompatConfig.setReplaceAll(Build.VERSION.SDK_INT < Build.VERSION_CODES.O);
EmojiCompat.init(fontRequestEmojiCompatConfig); EmojiCompat.init(fontRequestEmojiCompatConfig);
} }