Daniel Gultsch
9897fa3a45
rename initiateIceRestart to renegotiate to handle content adds
2022-11-21 09:10:01 +01:00
Daniel Gultsch
304205b2e3
take senders attr into account when converting to and from sdp
2022-11-20 17:00:40 +01:00
Daniel Gultsch
8fb2c11771
use plurals for missed call strings
2022-11-19 08:14:50 +01:00
Dmitry Markin
a6b88ba9e9
Add missed call notifications
...
Co-authored-by: Daniel Gultsch <daniel@gultsch.de>
2022-08-29 12:41:35 +02:00
Daniel Gultsch
62a379862e
jingle rtp: improve logging and error reporting
2022-08-01 10:14:49 +02:00
Daniel Gultsch
372078629b
fix ice candidate sending when different credentials are used
2022-02-25 17:26:36 +01:00
Daniel Gultsch
1f772df74f
remove security check that ensures rtp connection was properly finished
...
this only causes race conditions
2022-02-25 16:24:16 +01:00
Daniel Gultsch
d7f38a3e5a
fix precondition for timeout handling
2022-02-12 10:19:54 +01:00
Daniel Gultsch
db834a1f07
indicate call reconnect in notification
2021-11-19 12:26:11 +01:00
Daniel Gultsch
a508a81553
externalize rtc config generation into seperate method
2021-11-17 11:33:15 +01:00
Daniel Gultsch
61fb38cd84
clean up some error handling error ICE restarts
2021-11-17 10:49:16 +01:00
Daniel Gultsch
0a18c8613f
assume credentials are the same for all contents when restarting ICE
2021-11-16 17:08:34 +01:00
Daniel Gultsch
abb671616c
synchronize setDescription calls
2021-11-16 15:17:12 +01:00
Daniel Gultsch
297a843b9c
use implicit rollback (needed to be enabled on libwebrtc)
2021-11-16 13:17:10 +01:00
Daniel Gultsch
0698fa0d8c
store peer dtls setup for later use in ice restart
2021-11-16 11:21:11 +01:00
Daniel Gultsch
70b5d8d81a
set proper peer dtls setup on ice restart received
2021-11-15 21:49:31 +01:00
Daniel Gultsch
0a3947b8e3
terminate with application failure when failing to apply ICE restart
...
This is fairly unlikely to happen in practice
2021-11-15 17:18:45 +01:00
Daniel Gultsch
3f402b132b
respond with tie-break to prevent ICE restart race
2021-11-15 13:03:04 +01:00
Daniel Gultsch
5b80c62a63
treat transport-info w/o candidates and changed credentials as offer
2021-11-14 18:22:18 +01:00
Daniel Gultsch
717c83753f
delay discovered ice candidates until JingleRtpConnection is ready to receive
...
otherwise setLocalDescription and the arrival of first candidates might race
the rtpContentDescription being set
2021-11-11 21:02:17 +01:00
Daniel Gultsch
b6dee6da6a
reverse: webrtc: include oldState in onConnectionChange
...
turns out we don’t need it and a better way is for RtpConnection to keep track of *all*
states in the current generation
2021-11-11 17:05:36 +01:00
Daniel Gultsch
9c3f55bef2
use stopwatch to keep track of jingle rtp session duration
2021-11-11 16:52:18 +01:00
Daniel Gultsch
61851e5f84
do not automacially hang up failed webrtc sessions
2021-11-11 14:40:15 +01:00
Daniel Gultsch
4ec0996dff
webrtc: include oldState in onConnectionChange
2021-11-11 11:19:37 +01:00
Daniel Gultsch
fda45a7c86
use implicit descriptions for WebRTC
...
using the parameter-free form of setLocalDescription() solves some potential race conditions
that can occur - especially once we introduce restartIce()
2021-11-10 16:40:24 +01:00
Daniel Gultsch
20e4d108d4
fixed regression of not handling jingle content map parsing failures
2021-10-05 15:43:05 +02:00
Daniel Gultsch
63f5f8c89d
modify TODOs in JingleRtpConnection upon better understanding of the WebRTC stack
2021-09-08 10:47:34 +02:00
Daniel Gultsch
67e5f839f1
ignore crypto callbacks when rtp session has already been terminated
2021-05-08 11:50:18 +02:00
Daniel Gultsch
8d391753d7
encrypt rtp map as future
2021-05-08 08:45:31 +02:00
Daniel Gultsch
337aa4a110
consider Config.REQUIRE_RTP_VERIFICATION on decrypt. fail as future
2021-05-07 22:55:20 +02:00
Daniel Gultsch
ddf597e0d3
invoke x509 verification upon receiving prekey message in rtp session
2021-05-06 18:40:35 +02:00
Daniel Gultsch
e2324209ed
make sure omemo sessions are verified if the the respective config flag is set
2021-05-04 19:04:01 +02:00
Daniel Gultsch
48156dd27f
a/v calls: seperate out SECURITY error from APP_FAILURE
...
until now problems with verifying the call (omemo or DTLS missing) would
just be another app failure. This commit displays verifications problems as
their own thing.
2021-05-04 10:10:34 +02:00
Daniel Gultsch
9fc04c4b1e
when receiving out-of-order session-init in terminal state do not move to terminal again
...
fixes #4049
2021-04-08 10:23:39 +02:00
Daniel Gultsch
2681ad82e1
complain if mLineIndex can not be found when receiving candidates
2021-03-16 18:52:25 +01:00
Daniel Gultsch
c5f801c1fe
do not push empty candidates to backlog
2021-03-03 13:12:10 +01:00
Daniel Gultsch
d52c46d582
use omemo verification only if omemo is enabled in conversation
2021-03-03 12:55:27 +01:00
Daniel Gultsch
3ee70b1d48
show verified shield in rtp session activity
2021-03-03 09:41:05 +01:00
Daniel Gultsch
e4b2bb4a42
throw exception when unable to encrypt
2021-03-03 08:22:21 +01:00
Daniel Gultsch
8a6430ae29
ground work for omemo dtls verification
2021-03-02 21:13:49 +01:00
Daniel Gultsch
484f633180
let Conversations (not Android) play ringtone and vibration
...
fixes #3972 fixes #3801 fixes #3931
2021-02-18 20:55:31 +01:00
Daniel Gultsch
72e268e6b1
add TODO comments wrt to missing <retract/> parsing
2021-02-18 09:36:51 +01:00
Daniel Gultsch
7330d8a7f0
fixed race conditions around PROCEED state. fixes #3989
2021-02-11 16:56:57 +01:00
Daniel Gultsch
d158eeaf72
terminate jingle call when regular call starts
2020-08-24 12:47:54 +02:00
Daniel Gultsch
15b323ee69
fix crash after session-accept failed and session-accept contained candidates
...
Conversations would attempt to feed any candidates found in the session-accept into
WebRTC; even if the session wasn’t setup correctly.
this commit processes the candidates only if the session was setup correctly
fixes #3867
2020-08-22 08:12:28 +02:00
Daniel Gultsch
637c0cb15a
fixed rare race condition when receiving transport info right after WebRTCWrapper closes
...
fixes #3849
2020-08-01 14:18:03 +02:00
Daniel Gultsch
1ae7d6be16
recover from pre-jingle connection states (discover etc) into full fledged jingle connection
...
fixes #3847
2020-08-01 09:50:54 +02:00
Daniel Gultsch
f22e33e3ea
fixed race condition of WebRTCWrapper being closed before transitioning into terminal state
...
JingleRTPConnection shuts down the WebRTCWrapper before transitioning into a terminal state.
(This allows us to make sure it is actually closed when reaching that state);
However that means that, when we get a UI redrawn inbetween closing and transitioning we might
still be in SESSION_ACCEPTED but with no PeerConnection. This traditionally has triggered
an IllegalStateException on getting the EndUserState.
This commit catches the ISE and returns 'ENDING' instead.
Chances are that this is only visibiliy for a very brief time in the UI before the transition
triggers the UI to redraw with the proper state.
fixes #3848
2020-08-01 08:20:10 +02:00
Daniel Gultsch
6a6c9fb3bf
ignore race condition when toggling fixes #3822
2020-07-09 19:14:28 +02:00
Daniel Gultsch
fada3a63c9
store entire transport info for after session was accepted. fixes #3790
2020-06-22 18:07:27 +02:00