narayana/anotherim
narayana/anotherim
3
2
Fork 0
Code Issues 3 Pull requests 2 Actions Packages Projects Releases 4 Wiki Activity

Close DatagramSocket using try-with-resources

Browse source
This commit is contained in:
Florian Schmaus 2014-06-08 13:33:14 +02:00
parent 3236432c39
commit defe519101
1 changed files with 12 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
src/main/java/de/measite/minidns/Client.java
View file

@ -131,18 +131,19 @@ public class Client {
message.setRecursionDesired(true); message.setRecursionDesired(true);
message.setId(random.nextInt()); message.setId(random.nextInt());
byte[] buf = message.toArray(); byte[] buf = message.toArray();
DatagramSocket socket = new DatagramSocket(); try (DatagramSocket socket = new DatagramSocket()) {
DatagramPacket packet = new DatagramPacket( DatagramPacket packet = new DatagramPacket(buf, buf.length,
buf, buf.length, InetAddress.getByName(host), port); InetAddress.getByName(host), port);
socket.setSoTimeout(timeout); socket.setSoTimeout(timeout);
socket.send(packet); socket.send(packet);
packet = new DatagramPacket(new byte[bufferSize], bufferSize); packet = new DatagramPacket(new byte[bufferSize], bufferSize);
socket.receive(packet); socket.receive(packet);
DNSMessage dnsMessage = DNSMessage.parse(packet.getData()); DNSMessage dnsMessage = DNSMessage.parse(packet.getData());
if (dnsMessage.getId() != message.getId()) { if (dnsMessage.getId() != message.getId()) {
return null; return null;
}
return dnsMessage;
} }
return dnsMessage;
} }
/** /**