narayana/anotherim
narayana/anotherim
3
2
Fork 0
Code Issues 3 Pull requests Actions Packages Projects Releases 4 Wiki Activity

Merge pull request #644 from SamWhited/barejidchecks

Browse source 
s/getResourcepart().isEmpty()/isBareJid()/ [EOM]
This commit is contained in:
Daniel Gultsch 2014-11-09 20:05:38 +01:00
parent 56b4ac1751 385bea0fe3
commit a45a343604
5 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/main/java/eu/siacs/conversations/entities/Account.java
View file

@ -83,7 +83,7 @@ public class Account extends AbstractEntity {
final String avatar) { final String avatar) {
this.uuid = uuid; this.uuid = uuid;
this.jid = jid; this.jid = jid;
if (jid.getResourcepart().isEmpty()) { if (jid.isBareJid()) {
this.setResource("mobile"); this.setResource("mobile");
} }
this.password = password; this.password = password;

2
src/main/java/eu/siacs/conversations/entities/MucOptions.java
View file

@ -244,7 +244,7 @@ public class MucOptions {
&& conversation.getBookmark().getNick() != null) { && conversation.getBookmark().getNick() != null) {
return conversation.getBookmark().getNick(); return conversation.getBookmark().getNick();
} else { } else {
if (!conversation.getContactJid().getResourcepart().isEmpty()) { if (!conversation.getContactJid().isBareJid()) {
return conversation.getContactJid().getResourcepart(); return conversation.getContactJid().getResourcepart();
} else { } else {
return account.getUsername(); return account.getUsername();

2
src/main/java/eu/siacs/conversations/parser/AbstractParser.java
View file

@ -69,7 +69,7 @@ public abstract class AbstractParser {
// TODO: Handle this? // TODO: Handle this?
from = null; from = null;
} }
String presence = from == null || from.getResourcepart().isEmpty() ? "" : from.getResourcepart(); String presence = from == null || from.isBareJid() ? "" : from.getResourcepart();
Contact contact = account.getRoster().getContact(from); Contact contact = account.getRoster().getContact(from);
long timestamp = getTimestamp(packet); long timestamp = getTimestamp(packet);
if (timestamp >= contact.lastseen.time) { if (timestamp >= contact.lastseen.time) {

2
src/main/java/eu/siacs/conversations/parser/MessageParser.java
View file

@ -40,7 +40,7 @@ public class MessageParser extends AbstractParser implements
finishedMessage.setRemoteMsgId(packet.getId()); finishedMessage.setRemoteMsgId(packet.getId());
finishedMessage.markable = isMarkable(packet); finishedMessage.markable = isMarkable(packet);
if (conversation.getMode() == Conversation.MODE_MULTI if (conversation.getMode() == Conversation.MODE_MULTI
&& !jid.getResourcepart().isEmpty()) { && !jid.isBareJid()) {
finishedMessage.setType(Message.TYPE_PRIVATE); finishedMessage.setType(Message.TYPE_PRIVATE);
finishedMessage.setCounterpart(packet.getFrom()); finishedMessage.setCounterpart(packet.getFrom());
finishedMessage.setTrueCounterpart(conversation.getMucOptions() finishedMessage.setTrueCounterpart(conversation.getMucOptions()

4
src/main/java/eu/siacs/conversations/parser/PresenceParser.java
View file

@ -56,7 +56,7 @@ public class PresenceParser extends AbstractParser implements
final Jid from = packet.getFrom(); final Jid from = packet.getFrom();
String type = packet.getAttribute("type"); String type = packet.getAttribute("type");
if (from.toBareJid().equals(account.getJid().toBareJid())) { if (from.toBareJid().equals(account.getJid().toBareJid())) {
if (!from.getResourcepart().isEmpty()) { if (!from.isBareJid()) {
if (type == null) { if (type == null) {
account.updatePresence(from.getResourcepart(), account.updatePresence(from.getResourcepart(),
Presences.parseShow(packet.findChild("show"))); Presences.parseShow(packet.findChild("show")));
@ -69,7 +69,7 @@ public class PresenceParser extends AbstractParser implements
Contact contact = account.getRoster().getContact(packet.getFrom()); Contact contact = account.getRoster().getContact(packet.getFrom());
if (type == null) { if (type == null) {
String presence; String presence;
if (!from.getResourcepart().isEmpty()) { if (!from.isBareJid()) {
presence = from.getResourcepart(); presence = from.getResourcepart();
} else { } else {
presence = ""; presence = "";