narayana/anotherim
narayana/anotherim
3
2
Fork 0
Code Issues 3 Pull requests Actions Packages Projects Releases 4 Wiki Activity

fix mime type detection in urls that have query params or an anchor

Browse source
This commit is contained in:
Daniel Gultsch 2021-10-14 17:30:55 +02:00
parent 6d2e406ee5
commit 3706981645
1 changed files with 27 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

39
src/main/java/eu/siacs/conversations/utils/MimeUtils.java
View file

@ -21,6 +21,8 @@ import android.net.Uri;
import android.provider.OpenableColumns; import android.provider.OpenableColumns;
import android.util.Log; import android.util.Log;
import com.google.common.base.Strings;
import java.io.File; import java.io.File;
import java.io.FileInputStream; import java.io.FileInputStream;
import java.io.IOException; import java.io.IOException;
@ -274,6 +276,8 @@ public final class MimeUtils {
add("image/ico", "ico"); add("image/ico", "ico");
add("image/ief", "ief"); add("image/ief", "ief");
add("image/heic", "heic"); add("image/heic", "heic");
add("image/heif", "heif");
add("image/avif", "avif");
// add ".jpg" first so it will be the default for guessExtensionFromMimeType // add ".jpg" first so it will be the default for guessExtensionFromMimeType
add("image/jpeg", "jpg"); add("image/jpeg", "jpg");
add("image/jpeg", "jpeg"); add("image/jpeg", "jpeg");
@ -587,22 +591,33 @@ public final class MimeUtils {
} }
public static String extractRelevantExtension(final String path, final boolean ignoreCryptoExtension) { public static String extractRelevantExtension(final String path, final boolean ignoreCryptoExtension) {
if (path == null || path.isEmpty()) { if (Strings.isNullOrEmpty(path)) {
return null; return null;
} }
String filename = path.substring(path.lastIndexOf('/') + 1).toLowerCase(); final String filenameQueryAnchor = path.substring(path.lastIndexOf('/') + 1);
int dotPosition = filename.lastIndexOf("."); final String filenameQuery = cutBefore(filenameQueryAnchor, '#');
final String filename = cutBefore(filenameQuery, '?');
final int dotPosition = filename.lastIndexOf('.');
if (dotPosition != -1) { if (dotPosition == -1) {
String extension = filename.substring(dotPosition + 1); return null;
// we want the real file extension, not the crypto one }
if (ignoreCryptoExtension && Transferable.VALID_CRYPTO_EXTENSIONS.contains(extension)) { final String extension = filename.substring(dotPosition + 1);
return extractRelevantExtension(filename.substring(0, dotPosition)); // we want the real file extension, not the crypto one
} else { if (ignoreCryptoExtension && Transferable.VALID_CRYPTO_EXTENSIONS.contains(extension)) {
return extension; return extractRelevantExtension(filename.substring(0, dotPosition));
} } else {
return extension;
}
}
private static String cutBefore(final String input, final char c) {
final int position = input.indexOf(c);
if (position > 0) {
return input.substring(0, position);
} else {
return input;
} }
return null;
} }
} }