narayana/anotherim
narayana/anotherim
3
2
Fork 0
Code Issues 3 Pull requests Actions Packages Projects Releases 4 Wiki Activity

close http download connection after download

Browse source
This commit is contained in:
Daniel Gultsch 2017-04-29 22:59:36 +02:00
parent 7ba81177c6
commit 1a72683b52
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/main/java/eu/siacs/conversations/http/HttpDownloadConnection.java
View file

@ -219,6 +219,7 @@ public class HttpDownloadConnection implements Transferable {
} }
return Long.parseLong(contentLength, 10); return Long.parseLong(contentLength, 10);
} catch (IOException e) { } catch (IOException e) {
Log.d(Config.LOGTAG,"io exception during HEAD "+e.getMessage());
throw e; throw e;
} catch (NumberFormatException e) { } catch (NumberFormatException e) {
throw new IOException(); throw new IOException();
@ -259,10 +260,10 @@ public class HttpDownloadConnection implements Transferable {
private void download() throws Exception { private void download() throws Exception {
InputStream is = null; InputStream is = null;
HttpURLConnection connection = null;
PowerManager.WakeLock wakeLock = mHttpConnectionManager.createWakeLock("http_download_"+message.getUuid()); PowerManager.WakeLock wakeLock = mHttpConnectionManager.createWakeLock("http_download_"+message.getUuid());
try { try {
wakeLock.acquire(); wakeLock.acquire();
HttpURLConnection connection;
if (mUseTor) { if (mUseTor) {
connection = (HttpURLConnection) mUrl.openConnection(mHttpConnectionManager.getProxy()); connection = (HttpURLConnection) mUrl.openConnection(mHttpConnectionManager.getProxy());
} else { } else {
@ -322,10 +323,14 @@ public class HttpDownloadConnection implements Transferable {
throw new FileWriterException(); throw new FileWriterException();
} }
} catch (CancellationException | IOException e) { } catch (CancellationException | IOException e) {
Log.d(Config.LOGTAG,"http download failed "+e.getMessage());
throw e; throw e;
} finally { } finally {
FileBackend.close(os); FileBackend.close(os);
FileBackend.close(is); FileBackend.close(is);
if (connection != null) {
connection.disconnect();
}
wakeLock.release(); wakeLock.release();
} }
} }