Commit graph

408 commits

Author SHA1 Message Date
LAGonauta 064541dd2b Prefer primary DirectSound device on Windows
It automatically selects the default device for use,
there is no book keeping necessary and things just work

The primary DirectSound device has a (NULL) guid, making
it wasy to be found.
2021-06-09 07:20:33 -03:00
LAGonauta 854818133e DelegateToUi must be an owned function 2021-06-09 07:20:14 -03:00
LAGonauta 878bf9ac43 Allow null header, body, applogo, and image on notification builder 2021-06-09 07:20:14 -03:00
LAGonauta e6a521ada9 Add support for inline images to notification 2021-06-09 07:20:14 -03:00
LAGonauta 359dcbf70c Add support for adaptive Windows 10 notifications 2021-06-09 07:20:14 -03:00
mjk c40775b7da comment out unused arguments [-Wunused-parameter] 2021-06-09 07:20:13 -03:00
mjk 934b492357 init Callback completely always
The `token` pointer was left dangerously uninitialized after construction.
2021-06-09 07:20:12 -03:00
mjk 0258980977 replace lists with vectors 2021-06-09 07:20:12 -03:00
mjk 8034a6f344 remove the no-longer-needed -municode compile option 2021-06-09 07:20:10 -03:00
mjk c89671af04 log SetCurrentProcessExplicitAppUserModelID errors 2021-06-09 07:20:10 -03:00
mjk 822b91f40c stop checking for empty AUMIDs
The downstream code handles them just fine.
2021-06-09 07:20:09 -03:00
mjk 332216e63c reflow/respace 2021-06-09 07:20:09 -03:00
mjk 7b6f3ea9f6 replace C-style concurrent initialization of statics
C++ statics are thread-safe as is and are usually implemented more
efficiently. Besides, `volatile` is likely misused here anyway.
2021-06-09 07:20:04 -03:00
mjk 8988b77d57 don't use FALSE as a null pointer constant 2021-06-09 07:20:03 -03:00
mjk 987eb672d5 fix / work around uninitialized fields warnings 2021-06-09 07:20:03 -03:00
mjk 1698d15f7d silence enum stringification warnings by first casting to underlying types 2021-06-09 07:20:02 -03:00
mjk 17c1172d84 work around a (pedantic) format specifier warning 2021-06-09 07:20:02 -03:00
mjk 8f8dfa2e70 move module loading functions out of shortcutcreator.cpp 2021-06-09 07:20:02 -03:00
mjk e8d84d2eda handle empty menu-relative shortcut paths 2021-06-09 07:20:01 -03:00
mjk f1bcb6604f rewrite InitApartment and protect callers from (the rest of the) exceptions
Initializing COM by calling `winrt::init_apartment()` would always cause
stack unwinding *in practice*, which is suboptimal at best, and even using
`apartment_type::single_threaded` still would require exception filtering
*just in case*.
2021-06-09 07:20:01 -03:00
mjk c855d5e7cb protect GetTemplateContent callers from exceptions 2021-06-09 07:20:00 -03:00
mjk ed7c23c8d2 generalize glib::try_invoke to any return-by-value type and void 2021-06-09 07:19:59 -03:00
mjk b1cb64d716 add nullary version of g_try_invoke macro 2021-06-09 07:19:58 -03:00
mjk da424fb73b fiddle with punctuation 2021-06-09 07:19:58 -03:00
mjk 39b51b2d4c make glib::impl::varstring less explosive 2021-06-09 07:19:57 -03:00
mjk 7cb6b3f4b3 fix UB in glib::describe_arguments called with no arguments
Makes failure logging of nullary invokables non-crashy.
2021-06-09 07:19:56 -03:00
mjk 15abe70fc6 handle theoretical future failures of wsview_to_char 2021-06-09 07:19:56 -03:00
mjk ab6ce05aec handle empty hresult_error message specially 2021-06-09 07:19:55 -03:00
mjk c44b1daaf7 make meta-error messages more precise 2021-06-09 07:19:54 -03:00
mjk 5e50d1d2d7 remove an unused include 2021-06-09 07:19:53 -03:00
mjk d3214188d5 use lower-case 0x prefix for hresult code formatting everywhere 2021-06-09 07:19:51 -03:00
mjk 229ff697c4 move some whitespace around 2021-06-09 07:19:50 -03:00
mjk c3624f8490 handle exe paths longer than 259 chars 2021-06-09 07:19:48 -03:00
mjk 597061aed1 work around GetEnvironmentVariable not resetting last error 2021-06-09 07:19:48 -03:00
mjk fd035084de unimplement accidentally implemented wide string overloads of describe_argument 2021-06-09 07:19:47 -03:00
LAGonauta 426f997f9b Fix notifications not hiding 2021-06-09 07:19:47 -03:00
LAGonauta c60e0a828f Add README.md to Windows notification plugin 2021-06-09 07:19:46 -03:00
LAGonauta cc0e206c27 Removed unused library on linker
It is loaded dynamically
2021-06-09 07:19:45 -03:00
LAGonauta 60791cb3f0 Add ginvoke to CMakeLists 2021-06-09 07:19:45 -03:00
mjk f9a3b28624 switch to runtime loading of PropVariantToStringAlloc
Now it really should work.
2021-06-09 07:19:44 -03:00
mjk cb3c6874bc add restoration of shortcut's target path 2021-06-09 07:19:44 -03:00
mjk eeda464ca9 rewrite shortcut management code with RAII, error logging and exceptions
It actually works now.
2021-06-09 07:19:43 -03:00
mjk f193948f4e constify all the things 2021-06-09 07:19:43 -03:00
mjk 401c4a1bb1 change some local functions' signatures 2021-06-09 07:19:43 -03:00
mjk 34519e96bd make GetEnv more robust and not limit length of variables 2021-06-09 07:19:42 -03:00
mjk fb754b0d43 generalize GetShortcutPath into GetEnv 2021-06-09 07:19:42 -03:00
mjk 2eb1eea06e clarify GetCurrentModulePath's name 2021-06-09 07:19:41 -03:00
mjk 5b40d166d2 make GetCurrentModulePath and GetShortcutPath throw win32 errors 2021-06-09 07:19:41 -03:00
mjk 2ad659f777 clarify some entry points' names 2021-06-09 07:19:40 -03:00
mjk b21066c89e mark exception-safe C entry points as such 2021-06-09 07:19:40 -03:00